-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin dev ux improvements #992
Plugin dev ux improvements #992
Conversation
You can set a setting for only the local workspace in VSCode, assuming you use that. If you don't, then idk. |
Oh yeah I could add a .vscode folder to the repo so everyone using vscode gets LSP support, totally forgot I could do that lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, could you do some stuff for me? 😅
I use Emacs with eglot-luau, and for project-specific configuration I need a file called .dir-locals.el
. To match your VS Code settings here, I'd need a .dir-locals.el
under the project root containing the following:
((nil . ((eglot-luau-rojo-project-path . "plugin.project.json")
(eglot-luau-rojo-sourcemap-enabled . 't))))
Since I and my Emacs represent the vast minority of those that will ever interact with this project, I don't necessarily want this file tracked in source control, and would be totally fine with just adding .dir-locals.el
to .gitignore
; but, I'm not necessarily against it either...
Added :) |
I read the diff incorrectly, lol - we still only have one project file. The bit about cajoling VS Code to start the language server in a specific subdir still stands though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to change the "Build Plugin" step in our GA release workflow to use the new project file, and this should be good to go:
rojo/.github/workflows/release.yml
Lines 33 to 34 in 8c33100
- name: Build Plugin | |
run: rojo build plugin --output Rojo.rbxm |
So, somewhat annoyingly, we also have to modify the build script to have a |
It's pretty annoying to work on the plugin because the Luau LSP doesn't support nested project files (ie:
plugin/...json
) & the handy scripts for common actions are not uniform and undocumented. Also, the unit tests are flaky (at least on my machine) cuz it doesn't useWaitForChild
onReplicatedStorage
descendants.